chore: upgraded Gradle to 8.7.1 #187
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed redundant configuration
|
@Harry-Chen Any thoughts on this? |
Harry-Chen
added a commit
that referenced
this pull request
Dec 20, 2024
Now it requires at least Java 17 and Gradle 8.9. See #179, #184, #187 Signed-off-by: Shengqi Chen <[email protected]>
|
@larssn Sorry for the late reply. I think Java 8 is too legacy these days. But I merged all your other changes in master. Maybe it you are using old devices, you can use some tricks like matanshukry/flutter_google_places_sdk#71 (comment) to override the settings in this project? Also, could you try the latest master branch when available? |
|
Oh I see -- the review from #179 was also from you. So maybe using 1_8 is feasible now? |
|
Yeah I've done a lot of research on the topic, and using 1_8 is completely legit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Flutter now defaults to Gradle 8, I've taken the liberty of upgrading Gradle to 8.7.1.
Also ran through all the Gradle settings, and brought them up to date with the standard from a vanilla platform plugin.
Removed the Kotlin dependencies, as they are not needed.
Changed the build targets to Java 8, as minSdk 26 requires this:
compileOptions { sourceCompatibility JavaVersion.VERSION_1_8 targetCompatibility JavaVersion.VERSION_1_8 } kotlinOptions { jvmTarget = "1.8" }This should result in "correct" bytecode, which is also why Flutter is doing this.
Finally did a succesful test on a physical Pixel 5.
Closes #186
(All workarounds can also be removed)